Re: [PATCH 01/21] irq: add devres version of OF IRQ mapping routines

[Thomas Gleixner]

On Wed, 4 Jun 2014, nyushchenko@xxxxxxxxxxxxx wrote:

> From: Nikita Yushchenko <nyushchenko@xxxxxxxxxxxxx>
> 
> Many drivers use devres to manage their resources, and at the same time
> use irq_of_parse_and_map() / irq_dispose_mapping(). This creates problem
> on driver unload paths and on error paths:
> - it is invalid to call irq_dispose_mapping() while IRQ handler is still
>   installed,
> - devres moves removal of IRQ handler out of driver,
> - without explicit devres support for IRQ mapping, irq_dispose_mapping()
>   stays in driver and thus gets called while IRQ handler is still
>   installed.
> 
> This patch adds devm_irq_create_of_mapping() and devm_irq_of_parse_and_map()
> routines to be used by drivers for correct release of resources.
> 
> Signed-off-by: Nikita Yushchenko <nyushchenko@xxxxxxxxxxxxx>

Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/