Re: [PATCH 2/6] sched,trace: Add a tracepoint for remote wakeups via polling
From: Peter Zijlstra
Date: Wed Jun 04 2014 - 09:55:15 EST
On Wed, Jun 04, 2014 at 03:00:26PM +0200, Daniel Lezcano wrote:
> On 06/04/2014 02:29 AM, Andy Lutomirski wrote:
> >Remote wakeups of polling CPUs are a valuable performance
> >improvement; add a tracepoint to make it much easier to verify that
> >they're working.
> >
> >Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
>
> I don't think this trace makes sense. The polling state is x86 only and this
> trace is in the generic code.
Not so, there's PPC using it someplace (ISTR its doing a polling
amortization of the idle hypercall or somesuch) and there's archs that
have no other idle means that polling, as well as some for which its
optional.
There are indeed archs, like arm, that only do the WFI thing, and for
those this is indeed all a NOP.
Attachment:
pgp6YL0TLNl_i.pgp
Description: PGP signature