Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2

[Namhyung Kim]

Hi Andi,

2014-05-30 (ê), 14:50 -0700, Andi Kleen:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> Fix the logic to allow overriding event default periods with -c or -F
> on the command line.  I'm not sure I understand this if() fully, but
> this change makes all cases I tested work (tracepoint with default, default,
> ,-c, -F)

Are you sure you tested all cases after this patch applied?

When I apply it, it doesn't record any samples..

  $ perf record -a sleep 1
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.309 MB perf.data 
                 (~13494 samples) ]

  $ perf report --stdio
  Error:
  The perf.data file has no samples!
  # To display the perf.data header info,
  # please use --header/--header-only options.

  $ perf evlist -F
  cycles: sample_freq=0


Thanks,
Namhyung

> 
> This fixed specifying -c / -F with json event list events,
> which have a default period. It should do the same
> for trace point events.
> 
> Cc: fweisbec@xxxxxxxxx
> v2: Simplify, just change || to &&
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> ---
>  tools/perf/util/evsel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 5c28d82..d9ceede 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -592,7 +592,7 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)
>  	 * We default some events to a 1 default interval. But keep
>  	 * it a weak assumption overridable by the user.
>  	 */
> -	if (!attr->sample_period || (opts->user_freq != UINT_MAX &&
> +	if (!attr->sample_period && (opts->user_freq != UINT_MAX &&
>  				     opts->user_interval != ULLONG_MAX)) {
>  		if (opts->freq) {
>  			perf_evsel__set_sample_bit(evsel, PERIOD);



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/