Re: Fw: Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

[Sukadev Bhattiprolu]

Jiri Olsa [jolsa@xxxxxxxxxx] wrote:
| On Tue, Jun 03, 2014 at 12:47:10AM -0700, Sukadev Bhattiprolu wrote:
| 
| SNIP
| 
| > | 
| > | 
| > | could you please change this, so it's nop for arch != powerpc
| > | via #ifdef I guess.. or some other smart way ;-)
| > 
| > I was trying to avoid the #ifdef in the middle of the function.
| > 
| > How about adding a PERF_CONTEXT_IGNORE and doing something like this:
| 
| hum, 2 arch calls.. seems too complicated.. :-\

Other than an 'arch_' prefix in their name the non-powerpc functions
themselves are trivial, no ? 

| 
| so if you are already introducing PERF_CONTEXT_IGNORE, why
| dont we go with the chain duplication/fixing in arch code
| you mentioned before?
| 
| this way the callchain loop stays simple and it's extendbable
| to future changes (I think u mentioned we could change more
| than one entry in future..?)

The memdup() on each call chain entry can impact performance for
powerpc.  AFAICT, only one entry needs to be adjusted, so the memdup()
looked like an overkill.

| 
| thoughts.. anyone? ;-)
| 
| thanks,
| jirka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/