Re: [PATCH v2 1/2] block,scsi: verify return pointer from blk_get_request

From: Jeff Moyer
Date: Wed Jun 04 2014 - 15:36:44 EST


Joe Lawrence <joe.lawrence@xxxxxxxxxxx> writes:

> The blk-core dead queue checks introduce an error scenario to
> blk_get_request that returns NULL if the request queue has been
> shutdown. This affects the behavior for __GFP_WAIT callers, who should
> verify the return value before dereferencing.
>
> Signed-off-by: Joe Lawrence <joe.lawrence@xxxxxxxxxxx>
> Acked-by: Jiri Kosina <jkosina@xxxxxxx> [for pktdvd]
> Acked-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
> Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>

Heh. Just reviewed by would be better. ;-) I'm sure Jens can sort
that out.

-Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/