Re: [tip:x86/efi] x86/efi: Check for unsafe dealing with FPU state in irq ctxt

[H. Peter Anvin]

On 06/04/2014 03:15 PM, tip-bot for Borislav Petkov wrote:
> Commit-ID:  baa916f39b50ad91661534652110df40396acda0
> Gitweb:     http://git.kernel.org/tip/baa916f39b50ad91661534652110df40396acda0
> Author:     Borislav Petkov <bp@xxxxxxx>
> AuthorDate: Fri, 25 Apr 2014 13:40:10 +0200
> Committer:  Matt Fleming <matt.fleming@xxxxxxxxx>
> CommitDate: Sat, 3 May 2014 06:39:25 +0100
> 
> x86/efi: Check for unsafe dealing with FPU state in irq ctxt
> 
> efi_call can happen in an irq context (pstore) and there we really need
> to make sure we're not scribbling over FPU state while we've interrupted
> a thread or kernel mode with a live FPU state. Therefore, use the
> kernel_fpu_begin/end() variants which do that check.
> 
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
> Cc: Ricardo Neri <ricardo.neri-calderon@xxxxxxxxxxxxxxx>
> Signed-off-by: Matt Fleming <matt.fleming@xxxxxxxxx>
> ---
>  arch/x86/include/asm/efi.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

I seem to have lost track of this... does this actually solve anything,
or does it just mean we'll explode hard?

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/