Re: [PATCH] gpu: drm: msm: Replace type of paddr to uint32_t.

[Geert Uytterhoeven]

On Thu, Jun 5, 2014 at 2:05 AM, Rob Clark <robdclark@xxxxxxxxx> wrote:
> On Wed, Jun 4, 2014 at 6:54 AM, Matwey V. Kornilov <matwey@xxxxxxxxxx> wrote:
>> From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001
>> From: "Matwey V. Kornilov" <matwey.kornilov@xxxxxxxxx>
>> Date: Mon, 2 Jun 2014 20:17:29 +0400
>> Subject: [PATCH] Replace type of paddr to uint32_t.
>>
>> This patch helps to avoid the following build issue:
>>
>> drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of
>> 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror]
>>   msm_gem_get_iova_locked(fbdev->bo, 0, &paddr);
>>   ^
>> In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0:
>> drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but
>> argument is of type 'dma_addr_t *'
>>  int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id,
>>      ^
>>
>> Signed-off-by: Matwey V. Kornilov <matwey@xxxxxxxxxx>
>
> Reviewed-by: Rob Clark <robdclark@xxxxxxxxx>

Perhaps the uint32_t should become dma_addr_t instead?

drivers/gpu/drm/msm/msm_gem.h has:

        struct {
                // XXX
                uint32_t iova;
        } domain[NUM_DOMAINS];

(note the "XXX").

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/