Re: [tip:x86/efi] x86/efi: Check for unsafe dealing with FPU state in irq ctxt

From: Borislav Petkov
Date: Thu Jun 05 2014 - 12:21:02 EST


On Thu, Jun 05, 2014 at 09:14:51AM -0700, Andy Lutomirski wrote:
> Is this NMI pstore thing done from any context that's supposed to be
> recoverable? It's always safe to use the FPU and then panic :)

Right :)

> Anyway, if we're just talking about EFI, there's an easier solution:
> just preallocate a per-cpu FPU context for EFI and make the whole mess
> be local to the EFI code. For crypto, that's not so good.

This is probably something for Matt to decide but it sounds doable. If
I'd have to guess, sooner or later we will need to do proper FPU context
handling for EFI as I don't see anything stopping it from using FPU
insns. At least we won't. :-)

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/