Re: [PATCH 1/1] rtmutex: Handle when top lock owner changes

From: Thomas Gleixner
Date: Fri Jun 06 2014 - 01:44:33 EST


On Fri, 6 Jun 2014, Thomas Gleixner wrote:
> On Thu, 5 Jun 2014, Steven Rostedt wrote:
> > On Wed, 4 Jun 2014 17:32:37 +0200 (CEST)
> > Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > + /*
> > + * When we dropped the spinlocks, if the owner of the lock we
> > + * are currently processing changed since we chain walked
> > + * to that lock, we are done with the chain walk. The previous
> > + * owner was obviously running to release it.
> > + */
> > + if (lock && rt_mutex_owner(lock) != task)
> > + goto out_unlock_pi;
>
> NO. You CANNOT derefernce lock after dropping the locks. It might be
> gone already.

The only information we can check is, whether @task changed the
blocked on lock, really.

Thanks,

tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/