Re: [PATCH 1/2] powerpc/powernv: include asm/smp.h to handle UP config

[Benjamin Herrenschmidt]

On Fri, 2014-06-06 at 11:03 +0530, Anshuman Khandual wrote:
> On 06/05/2014 08:51 PM, Shreyas B. Prabhu wrote:
> > Build throws following errors when CONFIG_SMP=n
> > arch/powerpc/platforms/powernv/setup.c: In function âpnv_kexec_wait_secondaries_downâ:
> > arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of function âget_hard_smp_processor_idâ
> >     rc = opal_query_cpu_status(get_hard_smp_processor_id(i),
> > 
> > The usage of get_hard_smp_processor_id() needs the declaration from
> > <asm/smp.h>. The file setup.c includes <linux/sched.h>, which in-turn
> > includes <linux/smp.h>. However, <linux/smp.h> includes <asm/smp.h>
> > only on SMP configs and hence UP builds fail.
> > 
> > Fix this by directly including <asm/smp.h> in setup.c unconditionally.
> 
> Can you please clean up the description in the commit message ? and also
> the first line in the commit message should mention that the patch is
> trying to fix a UP specific build failure.

I don't understand your comment ... the description and subject line
are perfectly fine...

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/