Re: [PATCH] checkpatch: warn when patch exceeds a maximum message size

From: Joe Perches
Date: Fri Jun 06 2014 - 11:26:54 EST


On Fri, 2014-06-06 at 15:08 +0000, Allan, Bruce W wrote:
> > -----Original Message-----
> > From: Joe Perches [mailto:joe@xxxxxxxxxxx]
> > Sent: Thursday, June 05, 2014 6:36 PM
> > To: Allan, Bruce W
> > Cc: apw@xxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; postmaster
> > Subject: Re: [PATCH] checkpatch: warn when patch exceeds a maximum
> > message size
> >
> > On Thu, 2014-06-05 at 17:00 -0700, Bruce Allan wrote:
> > > the maximum message size (100,000 characters) allowed by Majordomo at
> > > vger.kernel.org since that is where most Linux email lists are served.
> >
> > I believe this is incorrect and the patch is unnecessary.
>
> Actually, it is correct (it even says so at http://vger.kernel.org/majordomo-info.html).

where?

All it says there that's relevant is:

------------------------------------------
All email sent to there must be TEXT/PLAIN, there can be no multipart
messages, no VCARDs, nothing ``fancy''. In presence of such things,
Majordomo will very likely do the wrong thing.

When you send there email, do make sure that all of the email headers,
both visible and transport level, have same addresses in them. People
experience problems when for example ``From:'', ``Sender:'' and possible
``Reply-To:'' headers present different addresses. The most common
manifestation is complete silence from VGER!
------------------------------------------

> We just experienced 2 out of 4 patches in the initial RFC submittal of the Intel(R)
> QuickAssist Technology (QAT) driver being blocked by Majordomo from getting out
> on the linux-crypto mailing list.

Possible, but the largest patch I've seen recently
on linux-kernel is about .5 Meg, 5 times your limit.

> It took a while to figure out the problem and had to
> break up those two blocked patches into smaller ones which went through fine. I
> submitted this checkpatch patch in hopes to prevent others from having to figure out
> the same.

Maybe specific to crypto?

> > It'd maybe more interesting if the email header sizes
> > were calculated and if > 1024, then some bleating message
> > were emitted.

This specific bit, email headers > 1K in total size,
is an actual failure mode btw.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/