Re: [GIT PULL] x86/vdso changes for v3.16

[Andy Lutomirski]

On Fri, Jun 6, 2014 at 2:07 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Jun 6, 2014 at 2:00 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>>
>> arch/x86/vdso/vdso2c.h: In function 'go64':
>> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le64toh'
>> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le32toh'
>> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le16toh'
>> arch/x86/vdso/vdso2c.h:119: warning: implicit declaration of function 'htole16'
>>
>> My Fedora Core 6 (lol gotcha) test box doesn't have these.
>
> Suggested fix: only use the helper functions on non-x86 (or
> non-little-endian) platforms.
>
> Peter, Andy?

The only real downside to that would be the chance of bitrot if that
code isn't getting used on native builds.

Blech.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/