Re: [boot regression PATCH] libata: allow xgene-ahci to opt-out of tag ordered submission

From: Dan Williams
Date: Fri Jun 06 2014 - 17:35:33 EST


On Fri, Jun 6, 2014 at 8:52 AM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> Ming Lei reports:
> "Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered
> controllers) causes below sata failure on APM AHCI controller.
>
> And the error does disappear after reverting the commit.
>
> ata4.00: exception Emask 0x40 SAct 0xff00 SErr 0x800 action 0x6 frozen
> ata4: SError: { HostInt }
> ata4.00: failed command: READ FPDMA QUEUED
> ata4.00: cmd 60/08:40:e0:a4:88/00:00:04:00:00/40 tag 8 ncq 4096 in
> res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x44 (timeout)"
>
> http://marc.info/?l=linux-kernel&m=140195842716315&w=2
>
> Maintain tag ordered submission as the default, but allow xgene-ahci to
> continue with the old behavior.
>
> Cc: Loc Ho <lho@xxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Cc: Tuan Phan <tphan@xxxxxxx>
> Cc: Dave Jiang <dave.jiang@xxxxxxxxx>
> Cc: Suman Tripathi <stripathi@xxxxxxx>
> Cc: Ed Ciechanowski <ed.ciechanowski@xxxxxxxxx>
> Cc: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> Tested-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>
> Reported-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---

Hold off on this as it appears an ahci_xgene fix is on its way.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/