Re: [GIT PULL] x86/vdso changes for v3.16

[H. Peter Anvin]

On 06/06/2014 02:33 PM, Andy Lutomirski wrote:
> On Fri, Jun 6, 2014 at 2:25 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>> On 06/06/2014 02:22 PM, Andy Lutomirski wrote:
>>>
>>> Sounds good.
>>>
>>> In the mean time, a trivial fix is here:
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=vdso/cleanup_fixes&id=cf780a0dc71f7cbd9a417e6ce2d5ddf56abccb74
>>>
>>> (or it will be once the mirrors sync)
>>>
>>
>> Unfortunately gcc didn't introduce __BYTE_ORDER__ at the compiler level
>> until 2010.  This makes it harder to do this in a portable manner.
> 
> Is there anything wrong with using __get_unaligned_leNN directly?
> 

Minus the double underscore (these files need to be cleaned up), not
really, and that is what my patch does.

For accessing memory members doing it via a pointer is pretty much TRT,
but for things that might be in register it is undesirable to force it
out to memory.

	-hpa



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/