Re: [PATCH 1/1] mm/zswap.c: add __init to zswap_entry_cache_destroy

From: Seth Jennings
Date: Sat Jun 07 2014 - 09:56:23 EST



On Jun 7, 2014 6:08 AM, Fabian Frederick <fabf@xxxxxxxxx> wrote:
>
> zswap_entry_cache_destroy is only called by __init init_zswap
>
> This patch also fixes function name
> zswap_entry_cache_ s/destory/destroy

Thanks for the improvement â

Acked-by <sjennings@xxxxxxxxxxxxxx>

>
> Cc: Seth Jennings <sjennings@xxxxxxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> ---
> mm/zswap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index aeaef0f..ab7fa0f 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -207,7 +207,7 @@ static int zswap_entry_cache_create(void)
> return zswap_entry_cache == NULL;
> }
>
> -static void zswap_entry_cache_destory(void)
> +static void __init zswap_entry_cache_destroy(void)
> {
> kmem_cache_destroy(zswap_entry_cache);
> }
> @@ -926,7 +926,7 @@ static int __init init_zswap(void)
> pcpufail:
> zswap_comp_exit();
> compfail:
> - zswap_entry_cache_destory();
> + zswap_entry_cache_destroy();
> cachefail:
> zbud_destroy_pool(zswap_pool);
> error:
> --
> 1.9.1
>