Re: [PATCH] media-device: Remove duplicated memset() in media_enum_entities()

From: Joe Perches
Date: Sat Jun 07 2014 - 11:55:32 EST


On Sat, 2014-06-07 at 16:41 +0200, Salva Peiró wrote:
> After the zeroing the whole struct struct media_entity_desc u_ent,
> it is no longer necessary to memset(0) its u_ent.name field.

trivia:

> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
[]
> @@ -106,8 +106,6 @@ static long media_device_enum_entities(struct media_device *mdev,
> if (ent->name) {
> strncpy(u_ent.name, ent->name, sizeof(u_ent.name));
> u_ent.name[sizeof(u_ent.name) - 1] = '\0';

this could be strlcpy too.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/