Re: [PATCH 2/2] Staging: speakup: ERROR: Fix macro parenthesis.

From: Dan Carpenter
Date: Sun Jun 08 2014 - 13:58:44 EST


It looks like this patch is adding blank lines not parenthesis like the
subject says.

regards,
dan carpenter

On Sun, Jun 08, 2014 at 11:12:57PM +0900, Choi Gi-yong wrote:
> Signed-off-by: Choi Gi-yong <yong@xxxxxxxx>
> ---
> drivers/staging/speakup/speakup_acntpc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/speakup_acntpc.c b/drivers/staging/speakup/speakup_acntpc.c
> index 31f952b..f70b698 100644
> --- a/drivers/staging/speakup/speakup_acntpc.c
> +++ b/drivers/staging/speakup/speakup_acntpc.c
> @@ -35,7 +35,7 @@
> #include "speakup_acnt.h" /* local header file for Accent values */
>
> #define DRV_VERSION "2.10"
> -#define PROCSPEECH '\r'
> +#define PROCSPEECH ('\r')
>
> static int synth_probe(struct spk_synth *synth);
> static void accent_release(void);
> @@ -152,8 +152,10 @@ static inline bool synth_full(void)
> static const char *synth_immediate(struct spk_synth *synth, const char *buf)
> {
> u_char ch;
> +
> while ((ch = *buf)) {
> int timeout = SPK_XMITR_TIMEOUT;
> +
> if (ch == '\n')
> ch = PROCSPEECH;
> if (synth_full())
> @@ -257,6 +259,7 @@ static int synth_probe(struct spk_synth *synth)
> {
> unsigned int port_val = 0;
> int i = 0;
> +
> pr_info("Probing for %s.\n", synth->long_name);
> if (port_forced) {
> speakup_info.port_tts = port_forced;
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/