Re: [PATCH v3] cpufreq: governor: Be friendly towards latency-sensitive bursty workloads

[Viresh Kumar]

On 8 June 2014 02:11, Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx> wrote:
> diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c

> +               if (unlikely(wall_time > (2 * sampling_rate)) &&
> +                                               j_cdbs->copy_prev_load) {
> +                       load = j_cdbs->prev_load;
> +                       j_cdbs->copy_prev_load = false;
> +               } else {
> +                       load = 100 * (wall_time - idle_time) / wall_time;
> +                       j_cdbs->prev_load = load;
> +                       j_cdbs->copy_prev_load = true;
> +               }

Hmm, slight modifications over the weekend :) ..
What do you think about removing this extra variable and using prev_load
only, i.e. make it zero in the else part? Also adding a comment for this would
be helpful ?

I will try a patch before you come to office :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/