Re: [PATCH 1/5] mfd: Add driver for Maxim 77802 Power Management IC

From: Mark Brown
Date: Mon Jun 09 2014 - 07:57:36 EST


On Mon, Jun 09, 2014 at 12:22:41PM +0200, Krzysztof Kozlowski wrote:
> On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote:

> > +static const struct max77802_irq_data max77802_irqs[] = {
> > + DECLARE_IRQ(MAX77802_PMICIRQ_PWRONF, PMIC_INT1, 1 << 0),
> > + DECLARE_IRQ(MAX77802_PMICIRQ_PWRONR, PMIC_INT1, 1 << 1),

> Why just not use two regmap_irq_chips (for PMIC and RTC blocks)
> replacing whole max77802-irq.c file?

If they share the same primary IRQ line something like what the arizona
drivers do should handle things well enough.

Attachment: signature.asc
Description: Digital signature