Re: [PATCH 1/1] platform/chrome: Probe multiple i2c adapters of the same name

[Mika Westerberg]

On Fri, Jun 06, 2014 at 11:25:14PM +0100, Scot Doyle wrote:
> The chromeos_laptop module probes the first i2c adapter with a specific name
> for expected hardware. However, the Acer C720 Chromebook has two i2c
> adapters with the same name. This patch probes each i2c adapter with a
> specific name in turn, until locating the expected hardware.
> 
> Signed-off-by: Scot Doyle <lkml14@xxxxxxxxxxxxx>
> CC: Benson Leung <bleung@xxxxxxxxxxxx>
> CC: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

I don't have anything against this approach.

One comment though, if you happen to have two devices with the same
address but in different buses this can go wrong. Not sure how likely
that will happen.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/