Re: [PATCH] blk-mq: add timer in blk_mq_start_request

[Jens Axboe]

On 06/09/2014 10:16 AM, Ming Lei wrote:
> This way will become consistent with non-mq case, also
> avoid to update rq->deadline twice for mq.
> 
> The comment said: "We do this early, to ensure we are on
> the right CPU.", but no percpu stuff is used in blk_add_timer(),
> so it isn't necessary. Even when inserting from plug list, there
> is no such guarantee at all.

Thanks, this is a good cleanup. That particular comment predates the
strict mappings of the queues, so it doesn't apply anymore anyway.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/