Re: [PATCH 2/2] dt-bindings: regulator: Add regulator suspend state for PM state

[Mark Brown]

On Mon, Jun 09, 2014 at 07:29:40PM +0900, Chanwoo Choi wrote:

> +- regulator-initial-state: initial state for suspend state
> +- regulator-state-[standby/mem/disk] sub-root node for suspend state
> +	regulator-volt: voltage consumers may set in suspend state
> +	regulator-mode: voltage mode in suspend state
> +	regulator-on-in-suspend: regulator should be on in suspend state
> +	regulator-off-in-suspend: regulator should be off in suspend state

These need to define what the states are in general terms - in
particular it's very unclear what standby is and how it differs from
suspend to RAM.  You also need to define what happens if neither
X-in-suspend property is set.

> +		regulator-state-mem {
> +			regulator-volt = <1000000>;
> +			regulator-mode = <0x8>;
> +			regulator-off-in-suspend;
> +		};

Probably best to remove mode from this.

Attachment: signature.asc
Description: Digital signature