Re: [PATCHv3 2/3] regulator: s2mps11: Add support S2MPU02 regulator device

[Mark Brown]

On Mon, Jun 09, 2014 at 03:15:47PM +0900, Chanwoo Choi wrote:
> This patch add S2MPU02 regulator device to existing S2MPS11 device driver
> because of little difference between S2MPS1x and S2MPU02. The S2MPU02
> regulator device includes LDO[1-28] and BUCK[1-7].

Acked-by: Mark Brown <broonie@xxxxxxxxxx>

but a few nits:

> +	case S2MPS14X:
> +		switch (rdev_id) {
> +		case S2MPS14_LDO3:
> +			return 0;
> +		};

Extra ; here, and a missing default case here and in the rest of the
switches.  The default cases have no effect but are better style.

Attachment: signature.asc
Description: Digital signature