Re: [patch V3 1/7] rtmutex: Deobfuscate chain walk

From: Lai Jiangshan
Date: Mon Jun 09 2014 - 23:47:27 EST


On 06/10/2014 04:59 AM, Steven Rostedt wrote:
> On Mon, 09 Jun 2014 20:28:06 -0000
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
>> There is no point to keep the task ref across the check for lock
>> owner. Drop the ref before that, so the protection context is clear.
>>
>> Found while documenting the chain walk.
>
> This looks fine, I just hate the subject. I don't see how it is
> 'deobfuscating" the chain walk. How about:
>
> rtmutex: No need to keep task ref when checking lock ownership
>
> Reviewed-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

Reviewed-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>

Thanks,
Lai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/