Re: [RESEND2 PATCH v4 2/2] i2c: sunxi: add P2WI (Push/Pull 2 Wire Interface) controller support

[Paul Carpenter]

Wolfram Sang wrote:
> On Tue, Jun 03, 2014 at 10:49:52AM +0200, Boris BREZILLON wrote:
> > The P2WI looks like an SMBus controller which only supports byte data
> > transfers. But, it differs from standard SMBus protocol on several
> > aspects:
> > - it supports only one slave device, and thus drop the address field
> > - it adds a parity bit every 8bits of data
> > - only one read access is required to read a byte (instead of a read
> >   followed by a write access in standard SMBus protocol)

Minor quibble should be
"(instead of a write followed by a read access in standard SMBus
  protocol)"

That being similar to EEPROM and other types of devices write internal
address followed by read access from internal address.

> > - there's no Ack bit after each byte transfer
> >
> > This means this bus cannot be used to interface with standard SMBus
> > devices (the only known device to support this interface is the AXP221
> > PMIC).
>
> Good description. Should be a comment at the top of the driver to spread
> the word.

--
Paul Carpenter          | paul@xxxxxxxxxxxxxxxxxxxxxxxxxxx
<http://www.pcserviceselectronics.co.uk/>    PC Services
<http://www.pcserviceselectronics.co.uk/pi/>  Raspberry Pi Add-ons
<http://www.pcserviceselectronics.co.uk/fonts/> Timing Diagram Font
<http://www.badweb.org.uk/> For those web sites you hate
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/