Re: [PATCH Resend] cpufreq: tegra: update comment for clarity
From: Rafael J. Wysocki
Date: Tue Jun 10 2014 - 16:58:03 EST
On Tuesday, June 10, 2014 10:27:12 AM Viresh Kumar wrote:
> Tegra's driver got updated a bit (00917dd cpufreq: Tegra: implement intermediate
> frequency callbacks) and implements new 'intermediate freq' infrastructure of
> core. Above commit updated comments about when to call
> clk_prepare_enable(pll_x_clk) and Doug wasn't satisfied with those comments and
> said this:
>
> > The "Though when target-freq is intermediate freq, we don't need to
> > take this reference." makes me think that this function is actually
> > called when target-freq is intermediate freq. I don't think it is,
> > right?
>
> For better clarity just make that comment more explicit about when we call
> tegra_target_intermediate().
>
> Reviewed-by: Stephen Warren <swarren@xxxxxxxxxx>
> Reported-and-reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
> Resend: Improved comment as suggested by Stephen.
Applied to bleeding-edge, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/