Re: [PATCH 05/10] mm, compaction: remember position within pageblock in free pages scanner

[Vlastimil Babka]

On 06/11/2014 04:12 AM, Minchan Kim wrote:
> > >@@ -314,6 +315,9 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
> > >  		int isolated, i;
> > >  		struct page *page = cursor;
> > >
> > >+		/* Record how far we have got within the block */
> > >+		*start_pfn = blockpfn;
> > >+
> Couldn't we move this out of the loop for just one store?

You mean using a local variable inside the loop, and assigning once, for 
performance reasons (register vs memory access)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/