Re: [PATCH v2] usb: host: uhci-grlib.c : use devm_ functions

[Alan Stern]

On Tue, 10 Jun 2014, Himangi Saraogi wrote:

> The various devm_ functions allocate memory that is released when a
> driver detaches. This patch uses devm_ioremap_resource for data
> that is allocated in the probe function of a platform device and
> is only freed in the remove function. The corresponding free functions
> are removed and two labels are done away with. Also, linux/device.h
> is added to make sure the devm_*() routine declarations are
> unambiguously available.
> 
> Signed-off-by: Himangi Saraogi <himangi774@xxxxxxxxx>
> Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
> ---
> v2: fix error of devm_ioremap_resource and change label names.


> +	hcd->regs = devm_ioremap_resource(&op->dev, hcd);

Obviously you haven't tried to compile this.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/