Re: [PATCH v7 3/5] misc: fuse: Add efuse driver for Tegra

[Peter De Schrijver]

On Wed, Jun 11, 2014 at 02:47:31PM +0200, Mikko Perttunen wrote:
> On 05/06/14 16:09, Peter De Schrijver wrote:
> ...
> > +int tegra_fuse_readl(u32 offset, u32 *val)
> > +{
> > +       if (!fuse_readl)
> > +               return -ENXIO;
> > +
> > +       *val = fuse_readl(offset);
> > +
> > +       return 0;
> > +}
> > +
> 
> -EPROBE_DEFER would be a better error value, so that drivers can work 

Ok.

> even if they are initially probed before the fuse driver. Of course, if 
> the fuse initialization is moved into machine init then this is a non-issue.

The exported function will always be initialized later because on Tegra20 it
requires APB DMA to be available. If you read the fuses directly, the system
sometimes hangs.

Cheers,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/