Re: [PATCH net-next] mrf24j40: separate h/w init and add checkings

[David Miller]

From: David Miller <davem@xxxxxxxxxxxxx>
Date: Thu, 12 Jun 2014 11:03:24 -0700 (PDT)

> From: Varka Bhadram <varkabhadram@xxxxxxxxx>
> Date: Thu, 12 Jun 2014 14:40:48 +0530
> 
>> separate the mrf24j40 hardware initialisation from probe()
>> and adds the sanity checkings.
>> 
>> These checkings are required if somebody hasn't a right spi configuration 
>> the probe function should fail. So we have to return from there.
>> 
>> Signed-off-by: Varka Bhadram <varkab@xxxxxxx>
> 
> Applied, thanks.

Reverted, did you even compile test this change?

drivers/net/ieee802154/mrf24j40.c: In function ʽmrf24j40_probeʼ:
drivers/net/ieee802154/mrf24j40.c:741:10: error: ʽerr_hw_initʼ undeclared (first use in this function)
drivers/net/ieee802154/mrf24j40.c:741:10: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ieee802154/mrf24j40.c:759:1: warning: label ʽerr_hw_initʼ defined but not used [-Wunused-label]
drivers/net/ieee802154/mrf24j40.c:702:5: warning: unused variable ʽvalʼ [-Wunused-variable]
make[1]: *** [drivers/net/ieee802154/mrf24j40.o] Error 1
make: *** [drivers/net/ieee802154/mrf24j40.o] Error 2