Re: [PATCH 02/12] percpu: introduce arch_raw_cpu_ptr()

From: Tejun Heo
Date: Fri Jun 13 2014 - 14:24:32 EST


On Fri, Jun 13, 2014 at 12:10:36PM -0500, Christoph Lameter wrote:
> On Thu, 12 Jun 2014, Tejun Heo wrote:
>
> > Currently, archs can override raw_cpu_ptr() directly; however, we
> > wanna build a layer of indirection in the generic part of percpu so
> > that we can implement generic features there without affecting archs.
>
> Not sure why one would do this. We already have this_cpu_ptr() (arch
> independant) and the lower level raw_cpu_ptr() which can be modified by
> the arch code.

So that there's separate between generic part of definition and
arch-specific part. This allows the generic portion of definition to
be handled in the generic code. e.g. arch no longer has to worry
about verifying arguments or having a data dependency barrier. It
just has to worry about the core implementation. The generic layer
can handle the boilerplates.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/