Re: [patch V4 10/10] rtmutex: Avoid pointless requeueing in the deadlock detection chain walk

[Thomas Gleixner]

On Fri, 13 Jun 2014, Steven Rostedt wrote:
> On Wed, 11 Jun 2014 18:44:09 -0000
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> Nit pick, but we should be consistent.
> 
> The requeue path does:
> 
>         next_lock = task_blocked_on_lock(task);
>         /*
>          * Store the top waiter of @lock for the end of chain walk
>          * decision below.
>          */
>         top_waiter = rt_mutex_top_waiter(lock);
> 
> I know the order is not important, but we should keep the two the same,
> helps in review and making sure changes to one implementation still
> make it to the other, without confusing those making the changes
> (like you in a few years ;)

The timespan for forgetting about that is measured in weeks, if at
all. No sane brain will keep itself exposed to this longer than
absolutely necessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/