Re: [PATCH 3/3][update] PM / sleep: Introduce command line argument for sleep state enumeration

From: Rafael J. Wysocki
Date: Fri Jun 13 2014 - 18:05:52 EST


On Saturday, June 14, 2014 12:16:26 AM Rafael J. Wysocki wrote:
> On Friday, June 13, 2014 11:46:12 PM Pavel Machek wrote:

[...]

> > > So I'm really not sure what's the problem? Do you think it's wrong to be
> > > helpful to users or something?
> >
> > It is not wrong to be helpful, but messed up interface is too big a
> > price.
>
> Why? I will have to maintain it after all, right?

And by the way, the very fact that this workaround is even useful in some cases
indicates that the interface that we've invented originally is not particularly
useful to user space. The reason why is because user space is supposed to
enumerate the sleep states and then present the ones that are present in a
consistent way to the user. It basically has to do "Is 'mem' present"? Use it
if so, but if not is 'standby' present? Use it if so etc." every time or
squirrel that information somewhere which isn't particularly straightforward.

So perhaps we should change the interface entirely?

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/