Re: [PATCH v5] leds: USB: HID: Add support for MSI GT683R led panels

[Janne Kanniainen]

> Hi!

Hi.

>> --- /dev/null
>> +++ b/Documentation/ABI/testing/sysfs-class-hid-driver-gt683r
>> @@ -0,0 +1,10 @@
>> +What:                /sys/class/hidraw/<hidraw>/device/state
>> +Date:                Jun 2014
>> +KernelVersion:       3.15
>> +Contact:     Janne Kanniainen <janne.kanniainen@xxxxxxxxx>
>> +Description:
>> +             Set the mode of LEDs
>> +
>> +             0 - normal
>> +             1 - audio
>> +             2 - breathing
>
> THat's some strange interface. Don't we normally use led triggers for this?

I can implement it that way, if you all think that it is correct way.
What do Jiri and Johan thinks of it?

> And the mode of the LED should really be in /sys/class/leds, not in hidraw somewhere...

The problem is that all panels can only be in one mode at the time.
For example front panel can't be in breathing mode while side panel is
in normal mode.


Janne
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/