Re: [PATCH V2] fs/omfs/inode.c: use ULLONG_MAX instead of ~0ULL

[Bob Copeland]

On Sun, Jun 15, 2014 at 08:39:20AM +0200, Fabian Frederick wrote:
> Use more explicit kernel.h definition
>  	array_size = DIV_ROUND_UP(bitmap_size, sb->s_blocksize);
>  
> -	if (sbi->s_bitmap_ino == ~0ULL)
> +	if (sbi->s_bitmap_ino == ULLONG_MAX)
>  		goto out;

So I agree they are the same, but is there a good reason for the
change?

Semantically, I think of ~0ULL as "all ones" whereas ULLONG_MAX
as a maximum of a magnitude comparison, which this is not really.

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/