Re: [PATCH 11/13] kexec-bzImage: Support for loading bzImage using 64bit entry

[H. Peter Anvin]

On 06/15/2014 09:35 AM, Borislav Petkov wrote:
> 
>> +	if (memcmp((char *)&header->header, "HdrS", 4) != 0) {
> 
> Not strncmp? "HdrS" is a string...
> 

No, memcmp() is more appropriate.  It is really more of a byte sequence
than a string.

It could just as easily be done as:

	header->header == 0x53726448

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/