Re: [PATCH v8 2/7] clocksource: Add support for the Mediatek SoCs

[Daniel Lezcano]

On 06/11/2014 08:14 PM, Thomas Gleixner wrote:
> On Wed, 11 Jun 2014, Matthias Brugger wrote:
> > +static void mtk_clkevt_mode(enum clock_event_mode mode,
> > +				struct clock_event_device *clk)
> > +{
> > +	struct mtk_clock_event_device *evt = to_mtk_clk(clk);
> > +
> > +	mtk_clkevt_time_stop(evt, GPT_CLK_EVT);
> > +
> > +	switch (mode) {
> > +	case CLOCK_EVT_MODE_PERIODIC:
> > +		mtk_clkevt_time_setup(evt, evt->ticks_per_jiffy, GPT_CLK_EVT);
> > +		mtk_clkevt_time_start(evt, true, GPT_CLK_EVT);
> > +		break;
> > +	case CLOCK_EVT_MODE_ONESHOT:
> > +		mtk_clkevt_time_start(evt, false, GPT_CLK_EVT);
>
> Why start the timer here? The code will call set next event right away.
>
> > +		break;
> > +	case CLOCK_EVT_MODE_UNUSED:
> > +	case CLOCK_EVT_MODE_SHUTDOWN:
> > +	default:
> > +		/* No more interrupts will occur as source is disabled */
> > +		break;
> > +	}
> > +}
>
> Looks good otherwise.

Hi Thomas,

Can I consider the 8.1 patch (the one taking into account your comment) 
as acked-by ?

Thanks

  -- Daniel


--
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/