Re: [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues

From: Anil Shashikumar Belur
Date: Mon Jun 16 2014 - 02:01:24 EST



> - result = +1; + result = + 1;
> This looks wrong.
> Here +1 is apparently meant as +1 (compare to -1) to underscore it's positive nature.
> If you wanted to drop the +, that'd be fine, I guess, but in your version it looks outright wrong to me (I tested and it compiles, though).
>
> Bye,
> Oleg
Hi Oleg,

While testing the value of `result` still remains "+1", from the above
change.

I agree as suggested, its better to remove `+` and use `result = 1;`
makes it more readable.

Will redo this patch and send.

Cheers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/