Re: [PATCH v4 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues

[Drokin, Oleg]

On Jun 16, 2014, at 7:13 AM, Anil Belur wrote:

> From: Anil Belur <askb23@xxxxxxxxx>
> 
> fixed: WARNING: line over 80 characters, used a new variable 'check' to
> store the offset. Replace "unsigned long" with  "u64" type fir
> 'cur_index'
> 
> Signed-off-by: Anil Belur <askb23@xxxxxxxxx>
> ---
> drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> index c180a20..440d7c2 100644
> --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> @@ -864,10 +864,11 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
> 				 * linux-2.6.18-128.1.1 miss to do that.
> 				 * --bug 17336 */
> 				loff_t size = cl_isize_read(inode);
> -				unsigned long cur_index = start >> PAGE_CACHE_SHIFT;
> +				u64 cur_index = start >> PAGE_CACHE_SHIFT;

Well, size is of type loff_t, so I imagine it's most natural to make cur_index to be loff_t too,
just like what you do with the newly added check (not very great name, btw, size_index?) variable

Bye,
    Oleg--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/