Re: [PATCH 3/6] metag,perf: Use common PMU interrupt disabled code

[James Hogan]

Hi Vince,

On 15/06/14 07:03, Vince Weaver wrote:
> 
> Transition to using the new generic PERF_PMU_CAP_NO_INTERRUPT method for
> failing a sampling event when no PMU interrupt is available.
> 
> Signed-off-by: Vince Weaver <vincent.weaver@xxxxxxxxx>


> @@ -866,6 +856,15 @@ static int __init init_hw_perf_events(void)
>  	pr_info("enabled with %s PMU driver, %d counters available\n",
>  			metag_pmu->name, metag_pmu->max_events);
>  
> +	/*
> +	 * Early cores have "limited" counters - they have no overflow
> +	 * interrupts - and so are unable to do sampling without extra work
> +	 * and timer assistance.
> +	 */
> +	if (metag_pmu->max_period == 0) {
> +		metag_pmu->pmu.capabilities |= PERF_PMU_CAP_NO_INTERRUPT;
> +	}

The braces could be dropped.

Otherwise looks good to me,

Acked-by: James Hogan <james.hogan@xxxxxxxxxx>

Cheers
James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/