Re: [PATCH V2] ARM: STi: DT: Properly define sti-ethclk & stmmaceth for stih415/6

From: Lee Jones
Date: Tue Jun 17 2014 - 03:10:48 EST


> On 06/16/2014 11:23 AM, Peter Griffin wrote:
> >This patch fixes two problems: -
> >
> >1) The device tree isn't currently providing sti-ethclk which is
> >required by the dwmac glue code to correctly configure the ethernet
> >PHY clock speed.
> >
> >This means depending on what the bootloader/jtag has
> >configured this clock to, and what switch/hub the board is plugged
> >into you most likely will NOT successfully negotiate a ethernet link.
> >
> >2) The stmmaceth clock was associated with the wrong clock. It was
> >referencing the PHY clock rather than the interconnect clock which
> >clocks the IP.
> >
> >This patch also brings us closer to not having to boot the upstream
> >kernel with the clk_ignore_unused parameter.
> >
> >Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> >---
> > arch/arm/boot/dts/stih415.dtsi | 8 ++++----
> > arch/arm/boot/dts/stih416.dtsi | 8 ++++----
> > include/dt-bindings/clock/stih415-clks.h | 1 +
> > include/dt-bindings/clock/stih416-clks.h | 1 +
> > 4 files changed, 10 insertions(+), 8 deletions(-)
>
> Acked-by: Maxime Coquelin <maxime.coquelin@xxxxxx>
>
> Thanks for the fix!

Can you apply Maxime and my Acks and send to ARM-SoC (CC'ed), due for
their -fixes branch please?

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/