Re: [PATCH] extcon: extcon-dra7xx: Add Extcon driver for DRA7xx

From: George Cherian
Date: Tue Jun 17 2014 - 08:29:34 EST


On 6/16/2014 7:45 PM, Guenter Roeck wrote:
On 06/15/2014 10:41 PM, George Cherian wrote:
On 6/16/2014 10:29 AM, Guenter Roeck wrote:
On 06/15/2014 07:42 PM, George Cherian wrote:
This is the driver for the USB ID pin detection. This driver
handles only the USB ID pin changes generated by cable
insertion/removal.

Signed-off-by: George Cherian <george.cherian@xxxxxx>

Hi George,

Curious: Why can't you use extcon-gpio ?
Main reason being missing dt support.

Then why not add dt support to it ?
Yes, I did sent a patch for the same.
http://marc.info/?l=linux-kernel&m=140297766828100&w=2
http://marc.info/?l=linux-kernel&m=140297771028124&w=2
http://marc.info/?l=linux-kernel&m=140297768828109&w=2


Also, I thought that Linux specific bindings would be unacceptable.
"ti,dra7xx-extcon" looks very linux specific to me. Did the rules change ?

Then how about "ti,extcon-usbid" ?

"extcon" seems very linux specific to me.

Anyway, not arguing, just asking, since I wondered. If the extcon maintainer
and the dt folks are happy with your driver, so am I.

Guenter



--
-George

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/