[PATCH 07/24] kernel: return actual error on param_sysfs_init

From: Jeff Liu
Date: Tue Jun 17 2014 - 10:29:21 EST


From: Jie Liu <jeff.liu@xxxxxxxxxx>

Return the actual error code if kset_create_and_add() failed

Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
---
kernel/params.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/kernel/params.c b/kernel/params.c
index 1e52ca2..a110987 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -928,10 +928,9 @@ struct kobj_type module_ktype = {
static int __init param_sysfs_init(void)
{
module_kset = kset_create_and_add("module", &module_uevent_ops, NULL);
- if (!module_kset) {
- printk(KERN_WARNING "%s (%d): error creating kset\n",
- __FILE__, __LINE__);
- return -ENOMEM;
+ if (IS_ERR(module_kset)) {
+ pr_warn("%s (%d): error creating kset\n", __FILE__, __LINE__);
+ return PTR_ERR(module_kset);
}
module_sysfs_initialized = 1;

--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/