Re: [PATCH 01/24] kobject: return actual error on kset_create_and_add

From: James Bottomley
Date: Tue Jun 17 2014 - 12:09:59 EST


On Tue, 2014-06-17 at 11:00 -0500, Christoph Lameter wrote:
> On Tue, 17 Jun 2014, Greg KH wrote:
>
> > Who really cares about that? What can do you do with that additional
> > information that will help anything out?
>
> The obvious reason for doing so is so that one can put the error code into
> a log message to get more detailed information on why the call failed.
>
> In this particular case the slab allocator can give an error message that
> gives a hint why the sysfs support could not be enabled.

What useful information does this supply? The current assumption on
NULL return is -ENOMEM ... what's the interesting case where this
assumption is wrong?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/