Re: [PATCH v2 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver

[Bartlomiej Zolnierkiewicz]

On Tuesday, June 17, 2014 10:42:36 AM Kumar Gala wrote:
> 
> On Jun 17, 2014, at 7:25 AM, Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> wrote:

[...]

> >> +static struct platform_driver qcom_ahci_driver = {
> >> +	.probe = qcom_ahci_probe,
> >> +	.remove = ata_platform_remove_one,
> >> +	.driver = {
> >> +		.name = "qcom_ahci_qcom",
> >> +		.owner = THIS_MODULE,
> >> +		.of_match_table = qcom_ahci_of_match,
> >> +	},
> > 
> > This driver lacks PM suspend/resume support.  I assume that
> > the IPQ806x platform also doesn't support suspend/resume yet
> > (if so a comment in the driver code about this would be useful),
> > otherwise the driver should be fixed.
> 
> Correct, do you want the comment in the commit message or the driver itself?

I would prefer the comment in the driver itself.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/