Re: [PATCH 1/1] scripts/coccinelle/free: add conditional kfree test

From: Joe Perches
Date: Tue Jun 17 2014 - 16:05:48 EST


On Tue, 2014-06-17 at 21:43 +0200, Fabian Frederick wrote:
> This patch adds a trivial script warning on
>
> if(foo)
> kfree(foo)
>
> (based on checkpatch)
[]
> diff --git a/scripts/coccinelle/free/cond_kfree.cocci b/scripts/coccinelle/free/cond_kfree.cocci
[]
> +* if (E)
> +* kfree@p(E);

You should probably add all of the unnecessary
conditional tests that checkpatch uses:

kfree
usb_free_urb
debugfs_remove
debugfs_remove_recursive


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/