Re: [PATCH 5/9] regulator: palmas: Shift the reg_info structure definition to the header file

[Keerthy]

On Tuesday 17 June 2014 10:02 PM, Lee Jones wrote:
> On Wed, 28 May 2014, Keerthy wrote:
>
> > Shift the reg_info structure definition to the header file.
> >
> > Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> > ---
> >   drivers/regulator/palmas-regulator.c |    9 ---------
> >   include/linux/mfd/palmas.h           |    9 +++++++++
> >   2 files changed, 9 insertions(+), 9 deletions(-)
> Patch looks fine.  I guess we'll wait and pull the entire set in once
> it's ready.
>
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

Thanks.

> > diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
> > index 9602eba..d41f3de 100644
> > --- a/drivers/regulator/palmas-regulator.c
> > +++ b/drivers/regulator/palmas-regulator.c
> > @@ -27,15 +27,6 @@
> >   #include <linux/of_platform.h>
> >   #include <linux/regulator/of_regulator.h>
> >   
> > -struct regs_info {
> > -	char	*name;
> > -	char	*sname;
> > -	u8	vsel_addr;
> > -	u8	ctrl_addr;
> > -	u8	tstep_addr;
> > -	int	sleep_id;
> > -};
> > -
> >   static const struct regulator_linear_range smps_low_ranges[] = {
> >   	REGULATOR_LINEAR_RANGE(500000, 0x1, 0x6, 0),
> >   	REGULATOR_LINEAR_RANGE(510000, 0x7, 0x79, 10000),
> > diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
> > index 52a24a9..150a6314 100644
> > --- a/include/linux/mfd/palmas.h
> > +++ b/include/linux/mfd/palmas.h
> > @@ -88,6 +88,15 @@ struct palmas {
> >   	u8 pwm_muxed;
> >   };
> >   
> > +struct regs_info {
> > +	char	*name;
> > +	char	*sname;
> > +	u8	vsel_addr;
> > +	u8	ctrl_addr;
> > +	u8	tstep_addr;
> > +	int	sleep_id;
> > +};
> > +
> >   struct palmas_gpadc_platform_data {
> >   	/* Channel 3 current source is only enabled during conversion */
> >   	int ch3_current;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/