Re: [PATCH net-next v2 1/3] ieee802154: cc2520: adds driver for TI CC2520 radio

[Mark Rutland]

On Wed, Jun 18, 2014 at 12:13:06PM +0100, Varka Bhadram wrote:
> On 06/18/2014 03:25 PM, Mark Rutland wrote:
> > On Wed, Jun 18, 2014 at 10:26:16AM +0100, Varka Bhadram wrote:
> >> +static int cc2520_probe(struct spi_device *spi)
> >> +{
> >> +       struct cc2520_private *priv;
> >> +       struct pinctrl *pinctrl;
> >> +       struct cc2520_platform_data *pdata;
> >> +       struct device_node __maybe_unused *np = spi->dev.of_node;
> >>
> >> This looks to be definitely unused rather than __maybe_unused. There are
> >> no other occuences of "np" in this function.
> >>
> >> This macro defined like this.
> >> #define __maybe_unused  __attribute__((unused))
> > Sure, but that's irrelevant. There's absolutely no point in this
> > variable existing at all, and it can simply disappear.
> >
> > Mark.
> 
> If we don't use that macro the compiler triggers warnings saying that:  warning: unused variable ânpâ [-Wunused-variable]

Then drop the _variable_, not just the annotation.

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/