Re: [PATCH] floppy: Neaten message logging

[Jiri Kosina]

On Wed, 18 Jun 2014, Joe Perches wrote:

> Use a more current style to prefix "floppy: " on
> all messages.
> 
> Convert DPRINT to emit at KERN_DEBUG.
> 
> Other miscellaneous logging changes:
> 
> o Add missing newline
> o Remove embedded "floppy" style prefixes

Why is this a good change?

[ ... ]
>  	if (!req) {
> -		pr_info("floppy.c: no request in request_done\n");
> +		pr_info("no request in request_done\n");

I think that in cases like this (and elsewhere where you are changing it 
in your patch) the prefix is actually useful.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/