[PATCH 1/1] [media] v4l: omap4iss: configuration using uninitialized variable

From: Heinrich Schuchardt
Date: Wed Jun 18 2014 - 18:31:46 EST


Variable reg is not initialized.
Random values are written to OMAP4 ISS registers if !ctx->eof_enabled.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx>
---
drivers/staging/media/omap4iss/iss_csi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/omap4iss/iss_csi2.c b/drivers/staging/media/omap4iss/iss_csi2.c
index bf8a657..9ae4871 100644
--- a/drivers/staging/media/omap4iss/iss_csi2.c
+++ b/drivers/staging/media/omap4iss/iss_csi2.c
@@ -317,7 +317,7 @@ static void csi2_ctx_enable(struct iss_csi2_device *csi2, u8 ctxnum, u8 enable)
static void csi2_ctx_config(struct iss_csi2_device *csi2,
struct iss_csi2_ctx_cfg *ctx)
{
- u32 reg;
+ u32 reg = 0;

/* Set up CSI2_CTx_CTRL1 */
if (ctx->eof_enabled)
--
2.0.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/